Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't take destructive action on esc #17779
Description of the Change
People instinctively hit escape to ignore alerts, so we shouldn't have it do something destructive.
We could also switch the button order but I kept it the same in most regards.
Maybe somebody memorized that hitting escape did the destructive thing? Seems unlikely.
Did the following in the console:
Hit escape after each and the window wasn't destroyed. Repeated, clicking the destructive buttons and it was.
@50Wliu Yeah I've mentioned this before. I don't remember if there is an issue for this.
This change will not work on Windows according to the api documentation. We need to change the label to be
From the electron api documentation: