New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comma-separated selectors as keys in Tree-sitter scope mappings #17781

Merged
merged 1 commit into from Aug 5, 2018

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Contributor

maxbrunsfeld commented Aug 5, 2018

Now that scope map values have a bit more structure (see #17738), it's nice to be able to avoid duplicating these values when they are used with multiple selectors. This PR allows the keys of a scope map to contain comma-separated selectors, similar to CSS.

@maxbrunsfeld maxbrunsfeld merged commit 554f1ba into master Aug 5, 2018

4 checks passed

VSTS: Atom Pull Requests 1.31.0-dev+20180805.1 succeeded
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-commas-in-scope-mapping-selectors branch Aug 5, 2018

@sakdaBoodprom

This comment was marked as spam.

Show comment
Hide comment
@sakdaBoodprom

sakdaBoodprom Aug 5, 2018

sakdaBoodprom commented Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment