New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CircleCI configuration #17788

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@jasonrudolph
Member

jasonrudolph commented Aug 6, 2018

tl;dr - Now that we're using VSTS for macOS builds, this pull request removes the CircleCI 1.0 build configuration before it is EOL at the end of the month.


Atom has historically used CircleCI for macOS builds. CircleCI announced that CircleCI 1.0 builds will no longer be available after August 31, 2018. That means that we either need to migrate to CircleCI 2.0 or find another solution for Atom's macOS builds.

Given that we recently implemented cross-platform builds (macOS, Linux, and Windows) on VSTS for Atom Nightly Releases (#17445, #17538), and given that we don't yet have a working CircleCI 2.0 configuration (#17445), it feels like the pragmatic choice is to use the already-working VSTS builds as our definitive macOS CI solution, and remove our soon-to-be-EOL CircleCI configuration.

@jasonrudolph jasonrudolph requested a review from daviwil Aug 6, 2018

@daviwil

daviwil approved these changes Aug 6, 2018

🎉

@jasonrudolph jasonrudolph merged commit 078a6ef into master Aug 6, 2018

3 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
VSTS: Atom Pull Requests 1.31.0-dev+20180806.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the remove-circleci branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment