New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up: apm@2.0.1 #17789

Merged
merged 4 commits into from Aug 6, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Aug 6, 2018

Description of the Change

Updates apm to 2.0.1 to benefit from the changes mentioned in this PR: atom/apm#803

Benefits

  • Shorter Atom installation paths on Windows
  • One step closer to having side-by-side installation channels on Windows #9247

Possible Drawbacks

None.

Verification Process

  • Run a full installer build on Windows to ensure that the installer can be built successfully and installs with much shorter paths
  • CI is green

Applicable Issues

#9247

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 6, 2018

Member

Here's the results of using npm 6.2.0 on a locally-built install of Atom vs Atom 1.29.0:

Before: Atom 1.29.0 Stable

PS C:\dev\atom> ls -R C:\Users\daviwil\AppData\Local\atom\ | ? { $_.FullName.Length -gt 180 } | sort { $_.FullName.Length } -Descending | % { "$($_.FullName) -> $($_.FullName.Length)" } | select -First 5
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\npmlog\node_modules\gauge\node_modules\string-width\node_modules\is-fullwidth-code-point\node_modules\number-is-nan\package.json -> 245
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\path-array\node_modules\array-index\node_modules\es6-symbol\node_modules\es5-ext\node_modules\es6-iterator\valid-iterable.js -> 241
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\npmlog\node_modules\gauge\node_modules\string-width\node_modules\is-fullwidth-code-point\node_modules\number-is-nan\index.js -> 241
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\npmlog\node_modules\gauge\node_modules\string-width\node_modules\is-fullwidth-code-point\node_modules\number-is-nan\license -> 240
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\path-array\node_modules\array-index\node_modules\es6-symbol\node_modules\es5-ext\number\max-safe-integer\is-implemented.js -> 239

Longest path: 245 characters

After: Atom 1.31.0 Dev

PS C:\dev\atom> ls -R C:\Users\daviwil\AppData\Local\atom\ | ? { $_.FullName.Length -gt 180 } | sort { $_.FullName.Length } -Descending | % { "$($_.FullName) -> $($_.FullName.Length)" } | select -First 5
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_changed_untracked_file\logs\refs\remotes\origin\_._ -> 195
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_added_and_uncommited\logs\refs\remotes\origin\_._ -> 193
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_changed_untracked_file\logs\refs\remotes\origin -> 191
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_changed_untracked_file\refs\remotes\origin\_._ -> 190
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_added_and_uncommited\logs\refs\remotes\origin -> 189

Longest path: 195 characters 🎉

Member

daviwil commented Aug 6, 2018

Here's the results of using npm 6.2.0 on a locally-built install of Atom vs Atom 1.29.0:

Before: Atom 1.29.0 Stable

PS C:\dev\atom> ls -R C:\Users\daviwil\AppData\Local\atom\ | ? { $_.FullName.Length -gt 180 } | sort { $_.FullName.Length } -Descending | % { "$($_.FullName) -> $($_.FullName.Length)" } | select -First 5
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\npmlog\node_modules\gauge\node_modules\string-width\node_modules\is-fullwidth-code-point\node_modules\number-is-nan\package.json -> 245
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\path-array\node_modules\array-index\node_modules\es6-symbol\node_modules\es5-ext\node_modules\es6-iterator\valid-iterable.js -> 241
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\npmlog\node_modules\gauge\node_modules\string-width\node_modules\is-fullwidth-code-point\node_modules\number-is-nan\index.js -> 241
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\npmlog\node_modules\gauge\node_modules\string-width\node_modules\is-fullwidth-code-point\node_modules\number-is-nan\license -> 240
C:\Users\daviwil\AppData\Local\atom\app-1.29.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\node_modules\path-array\node_modules\array-index\node_modules\es6-symbol\node_modules\es5-ext\number\max-safe-integer\is-implemented.js -> 239

Longest path: 245 characters

After: Atom 1.31.0 Dev

PS C:\dev\atom> ls -R C:\Users\daviwil\AppData\Local\atom\ | ? { $_.FullName.Length -gt 180 } | sort { $_.FullName.Length } -Descending | % { "$($_.FullName) -> $($_.FullName.Length)" } | select -First 5
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_changed_untracked_file\logs\refs\remotes\origin\_._ -> 195
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_added_and_uncommited\logs\refs\remotes\origin\_._ -> 193
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_changed_untracked_file\logs\refs\remotes\origin -> 191
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_changed_untracked_file\refs\remotes\origin\_._ -> 190
C:\Users\daviwil\AppData\Local\atom\app-1.31.0\resources\app\apm\node_modules\git-utils\deps\libgit2\tests\resources\submod2\.gitted\modules\sm_added_and_uncommited\logs\refs\remotes\origin -> 189

Longest path: 195 characters 🎉

@daviwil daviwil merged commit d625e85 into master Aug 6, 2018

3 checks passed

VSTS: Atom Pull Requests 1.31.0-dev+20180806.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-apm-2.0.1 branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment