New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom from WSL respects windows drive mount location defined in /etc/wsl.conf #17795

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@Jinivus
Contributor

Jinivus commented Aug 7, 2018

Description of the Change

Allows the default atom shell script to use the WSL windows drive mount point defined in /etc/wsl.conf

Why Should This Be In Core?

The current core supports WSL except for cases when the windows drive mount point is not default

Benefits

Any wsl.conf configured windows drive mount point will work instead of just the default

Possible Drawbacks

Potentially doesn't account for every edge case mount point?

Verification Process

  1. Change WSL default windows drive mount points to anything other than /mnt/%drive_letter%.
    This is done in the /etc/wsl.conf file, specified here
  2. Navigate to a directory on the windows filesystem inside WSL. Eg /c/dev/
  3. Run "atom ."

Applicable Issues

#17794

@Jinivus Jinivus changed the title from Fixes #17794 to Atom from WSL respects windows drive mount location defined in /etc/wsl.conf Aug 7, 2018

@50Wliu 50Wliu added the needs-testing label Aug 7, 2018

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 15, 2018

Member

I restarted the VSTS build and it succeeded despite what the PR build status says:

https://github.visualstudio.com/Atom/_build/results?buildId=4686&_a=summary&view=logs

Member

daviwil commented Aug 15, 2018

I restarted the VSTS build and it succeeded despite what the PR build status says:

https://github.visualstudio.com/Atom/_build/results?buildId=4686&_a=summary&view=logs

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 28, 2018

Member

Thanks @Jinivus!

Member

daviwil commented Aug 28, 2018

Thanks @Jinivus!

@daviwil daviwil merged commit 5f3b327 into atom:master Aug 28, 2018

2 of 3 checks passed

VSTS: Atom Pull Requests 20180807.1 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment