Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set VSTS build number in non-PR builds to avoid auth errors #17804

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented Aug 8, 2018

Description of the Change

This change fixes VSTS PR build errors we see when a non-maintainer sends a PR to this repo:

TF400813: The user '37997752-33c2-4c03-970c-cdc086fbc5e2' is not authorized to access this resource.

This error occurs due to a bug in VSTS which should be resolved in an upcoming release but for now this change will get us moving.

Alternate Designs

None.

Why Should This Be In Core?

It's for da build.

Benefits

Outside contributors get PR build runs.

Possible Drawbacks

None.

Verification Process

  • The VSTS build for this PR passes and doesn't have a custom build number

Applicable Issues

None.

@daviwil daviwil merged commit 0e9f465 into master Aug 8, 2018

3 checks passed

VSTS: Atom Pull Requests 20180808.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-fix-pr-auth-error branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.