Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stable and beta draft release creation on VSTS #17862

Merged
merged 14 commits into from Feb 8, 2019

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented Aug 14, 2018

Description of the Change

This PR adds logic to our VSTS release build definition to enable the creation of draft GitHub releases when successful builds are produced on release branches (those named 1.xx-releases).

NOTE: This change will not be turned on by default until 32-bit Windows builds are being produced on VSTS. This PR just adds the necessary release automation so that it's ready once those builds are being produced.

Alternate Designs

Why Should This Be In Core?

This is a build script for Atom.

Benefits

Draft releases are now created automatically for every successful build on a release branch. This removes the need for an Atom developer to go manually create a draft release with a separate internal tool.

This change also sets the stage for performing the final publishing steps with VSTS in an automated way.

Possible Drawbacks

None that I can think of.

Verification Process

  • Verify that a draft release successfully gets created from a simulated release build

This is a screenshot of a draft release created as a result of this build:

image

Applicable Issues

None.

TODO

  • Add changelog generation and save changelog from previously published release with the same version

@daviwil daviwil force-pushed the dw-draft-releases branch from e3b1b71 to 5f8bbe4 Oct 30, 2018

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Oct 31, 2018

The work is almost done here, just need to test with a few more simulated release builds before merging!

@daviwil daviwil force-pushed the dw-draft-releases branch from 9fcf6d2 to e366134 Feb 8, 2019

@daviwil daviwil changed the title WIP: Enable stable and beta draft release creation on VSTS Enable stable and beta draft release creation on VSTS Feb 8, 2019

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Feb 8, 2019

Merging this despite unrelated test flakes, planning to test-drive this for the upcoming release.

@daviwil daviwil merged commit af92156 into master Feb 8, 2019

2 of 3 checks passed

Atom Pull Requests #20190208.11 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-draft-releases branch Feb 8, 2019

daviwil added a commit that referenced this pull request Feb 11, 2019

Merge pull request #17862 from atom/dw-draft-releases
Enable stable and beta draft release creation on VSTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.