Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
During quit, close unloaded windows #17873
Description of the Change
When quitting the app (e.g. by Cmd-Q on macOS), in
When some of the windows end up unloading successfully, but the quit is stopped this way, these windows stay open, left in a weird unloaded state (Atom expects them to ultimately get closed by a quit, which doesn't happen). This adds logic to immediately close windows after they are successfully unloaded during a quit.
We could close the window in
Why Should This Be In Core?
It's a bugfix.
State restoration on other platforms? Everything worked fine in my testing on macOS.
I noticed this test failure on VSTS:
Not sure if this is caused by the change or a test flake so I've restarted the build to see if it goes green then next time.