New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nightly releases to auto-update #17886

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Aug 20, 2018

Description of the Change

This change removes a bad version check which prevented nightly releases to be considered for auto-update checks. The fix is to only skip auto-updates when using a build with a version containing -dev.

Alternate Designs

Could have used a more elaborate version check but this simple check accomplishes all of that just by turning off auto-updates for -dev-* versions.

Why Should This Be In Core?

This is a fix for auto-update behavior in Atom Nightly releases.

Benefits

Nightly releases will now automatically check for updates.

Possible Drawbacks

None that I know of.

Verification Process

  • Ensure that an Atom Dev build does not check for updates automatically (it should report that updates are not possible in the About page)
  • Build a fake Nightly build and test it on macOS to see if it checks for updates automatically when Atom starts up

Applicable Issues

Fixes #17885

Allow nightly releases to auto-update
This change removes a bad version check which prevented nightly releases 
to be considered for auto-update checks.  The fix is to only skip 
auto-updates when using a build with a version containing `-dev`.

Fixes #17885

@daviwil daviwil merged commit 82237e7 into master Aug 20, 2018

3 checks passed

VSTS: Atom Pull Requests 20180820.15 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-nightly-auto-updates branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment