New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_right: Migrate core package 'about' into ./packages #17893

Merged
merged 3 commits into from Aug 23, 2018

Conversation

Projects
None yet
3 participants
@daviwil
Member

daviwil commented Aug 21, 2018

Description of the Change

This PR migrates the core about package into atom/atom. See issue #17832 for more information.

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Aug 21, 2018

Contributor

I'm guessing we can also delete PULL_REQUEST_TEMPLATE.md, ISSUE_TEMPLATE.md, package-lock.json, .travis.yml, and appveyor.yml.

Contributor

maxbrunsfeld commented Aug 21, 2018

I'm guessing we can also delete PULL_REQUEST_TEMPLATE.md, ISSUE_TEMPLATE.md, package-lock.json, .travis.yml, and appveyor.yml.

@Arcanemagus

This comment has been minimized.

Show comment
Hide comment
@Arcanemagus

Arcanemagus Aug 21, 2018

Contributor

Should these repo specific files be being migrated?

  • .travis.yml
  • ISSUE_TEMPLATE.md
  • PULL_REQUEST_TEMPLATE.md
  • appveyor.yml

The package specs should be being run as part of Atom's own CI builds now, never mind the fact that they are now in a different repo, so the CI configurations are completely useless. The GitHub repo files are also pointless now as they are superseded by the Atom ones.

Contributor

Arcanemagus commented Aug 21, 2018

Should these repo specific files be being migrated?

  • .travis.yml
  • ISSUE_TEMPLATE.md
  • PULL_REQUEST_TEMPLATE.md
  • appveyor.yml

The package specs should be being run as part of Atom's own CI builds now, never mind the fact that they are now in a different repo, so the CI configurations are completely useless. The GitHub repo files are also pointless now as they are superseded by the Atom ones.

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 21, 2018

Member

Yes, they can be removed, I'll do that before merging.

Member

daviwil commented Aug 21, 2018

Yes, they can be removed, I'll do that before merging.

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 23, 2018

Member

Added a README.md with details about core package locations. This will be updated for future package migrations.

Member

daviwil commented Aug 23, 2018

Added a README.md with details about core package locations. This will be updated for future package migrations.

@daviwil daviwil requested review from jasonrudolph and maxbrunsfeld Aug 23, 2018

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 23, 2018

Member

VSTS failure is caused by issues they're having with Linux builds today, Windows and macOS builds are 🍏

Member

daviwil commented Aug 23, 2018

VSTS failure is caused by issues they're having with Linux builds today, Windows and macOS builds are 🍏

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Aug 23, 2018

Member

Gonna go ahead and get this merged so that I can move forward on finishing the migration of this package. Please let me know if there's anything else you'd like for me to address and I'll be happy to do it in another PR tomorrow!

Member

daviwil commented Aug 23, 2018

Gonna go ahead and get this merged so that I can move forward on finishing the migration of this package. Please let me know if there's anything else you'd like for me to address and I'll be happy to do it in another PR tomorrow!

@daviwil daviwil merged commit 8d48fc0 into master Aug 23, 2018

2 of 3 checks passed

VSTS: Atom Pull Requests 20180823.2 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-migrate-about branch Aug 23, 2018

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Aug 23, 2018

Contributor

📈 💥

Contributor

maxbrunsfeld commented Aug 23, 2018

📈 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment