New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Tree-sitter bugs found when enabling by default #17956

Merged
merged 2 commits into from Aug 30, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Aug 30, 2018

This PR extracts two bug fixes that I found as part of #17879:

  • Ensure that grammars' root scope descriptors are always included in scope descriptors, even for buffer positions for which there is no syntax node (i.e. leading or trailing whitespace in the file).
  • Tweak the logic for updating parse trees synchronously for quick parses such that it works when there are synchronous edits and multiple quick parses in a row.

/cc @joefitzgerald - I believe this fixes the bug you reported today

Fixes #17942

@maxbrunsfeld maxbrunsfeld merged commit 09181ac into master Aug 30, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Atom Pull Requests #20180830.3 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-fixes branch Aug 30, 2018

maxbrunsfeld added a commit that referenced this pull request Aug 30, 2018

Merge pull request #17956 from atom/mb-tree-sitter-fixes
Fix some Tree-sitter bugs found when enabling by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment