New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added capturing to keydown events when hiding tooltips #17958

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@cacheflow
Contributor

cacheflow commented Aug 30, 2018

Description of the Change
Fix #17957 by ensuring capturing occurs and the event is bubbled up to the window.

Alternate Designs
None.

Benefits
It fixes an issue where users may want to see the workspace they're typing in, but a tooltip is hiding it.

Possible Drawbacks
It adds an additional event listener for each tooltip.

Verification Process
I modified the existing tooltip-manager spec to include a new test for this feature, ran the test suite, and also manually tested it by reproducing the steps listed in #17957.

Before fix
tooltip-without-fix

After fix
tooltip-with-fix

Applicable Issues
#17957

@daviwil

daviwil approved these changes Sep 6, 2018

Restarted VSTS build failed for an unrelated reason, I think this PR is good. Thanks a lot @cacheflow!

@daviwil daviwil merged commit d0ecc65 into atom:master Sep 6, 2018

2 of 3 checks passed

Atom Pull Requests #20180830.5 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cacheflow cacheflow deleted the cacheflow:add-capturing-to-keydown-events-when-hiding-tooltips branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment