New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➡️ Migrate core package 'one-light-syntax' into ./packages #17981

Merged
merged 3 commits into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@jasonrudolph
Member

jasonrudolph commented Sep 5, 2018

Closes #17855.

Description of the Change

This PR migrates the core one-light-syntax package into atom/atom. See issue #17855 for more information.

@daviwil

daviwil approved these changes Sep 5, 2018

🎉

jasonrudolph added some commits Sep 6, 2018

@jasonrudolph

This comment has been minimized.

Show comment
Hide comment
@jasonrudolph

jasonrudolph Sep 6, 2018

Member

image

The VSTS build failed ☝️, but rebuilding it succeeded: https://github.visualstudio.com/Atom/_build/results?buildId=6424&view=logs

I'm not sure why the successful build didn't update the status of this PR.

Member

jasonrudolph commented Sep 6, 2018

image

The VSTS build failed ☝️, but rebuilding it succeeded: https://github.visualstudio.com/Atom/_build/results?buildId=6424&view=logs

I'm not sure why the successful build didn't update the status of this PR.

@jasonrudolph jasonrudolph merged commit 9127ddd into master Sep 6, 2018

2 of 3 checks passed

Atom Pull Requests #20180906.9 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the migrate-one-light-syntax-package branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment