New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow OS text selection in atom buffers. #17985

Merged
merged 3 commits into from Sep 6, 2018

Conversation

Projects
None yet
5 participants
@queerviolet
Contributor

queerviolet commented Sep 6, 2018

This admittedly odd-looking change disables OS-level text selection in Atom text buffers. We generally prevent native selection operations anyway (instead managing the selection ourselves), but in some cases (macOS right click, frex), we would still get one (which wouldn't be attached to anything, creating confusion and sowing discord).

Fixes #17799
Fixes atom/spell-check#251

@Aerijo

This comment has been minimized.

Show comment
Hide comment
@Aerijo

Aerijo Sep 6, 2018

Contributor

@queerviolet Also appears to fix atom/spell-check#251. The cursor still moves to the word, but that's a separate issue.

Contributor

Aerijo commented Sep 6, 2018

@queerviolet Also appears to fix atom/spell-check#251. The cursor still moves to the word, but that's a separate issue.

@daviwil

daviwil approved these changes Sep 6, 2018

Awesome, looks good!

@maxbrunsfeld

⚡️

@queerviolet

This comment has been minimized.

Show comment
Hide comment
@queerviolet

queerviolet Sep 6, 2018

Contributor

Ugh. What an annoying failure—the spec isn't quite testing the right thing. Copy/paste from MD preview does actually work. 😔

Contributor

queerviolet commented Sep 6, 2018

Ugh. What an annoying failure—the spec isn't quite testing the right thing. Copy/paste from MD preview does actually work. 😔

@queerviolet queerviolet merged commit 73ab237 into master Sep 6, 2018

3 checks passed

Atom Pull Requests #20180906.12 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@queerviolet queerviolet deleted the ak-no-selection-in-the-text-editing-room branch Sep 6, 2018

@matthewwithanm

This comment has been minimized.

Show comment
Hide comment
@matthewwithanm

matthewwithanm Sep 7, 2018

Member

thanks!! ❤️

Member

matthewwithanm commented Sep 7, 2018

thanks!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment