New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump modules that were updated for Node 10 / Electron 3 support #17988

Merged
merged 4 commits into from Sep 6, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Sep 6, 2018

Description of the Change

This change bumps a few npm modules that needed to be updated for Node 10 / Electron 3 support. Running a PR

Alternate Designs

None.

Why Should This Be In Core?

Updating core Atom dependencies.

Benefits

Moving closer to Node 10 / Electron 3 support for Atom.

Possible Drawbacks

Build breaks?

Verification Process

  • Wait for green CI builds

Applicable Issues

N/A

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 6, 2018

Member

CI looks good aside from the known Linux test flake on VSTS. All OSes accounted for.

Member

daviwil commented Sep 6, 2018

CI looks good aside from the known Linux test flake on VSTS. All OSes accounted for.

@daviwil daviwil merged commit 3f4feda into master Sep 6, 2018

2 of 3 checks passed

Atom Pull Requests #20180906.4 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-bump-modules branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment