Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix autocomplete icon #18016
Description of the Change
This fixes the icons in the autocomplete popover.
The selector used to win in specificity is pretty ugly, but we can't really change the class names because other packages and themes use it too.
Why Should This Be In Core?
It's a bundled package
Icon's background doesn't look broken anymore.
Even harder to override
None, pointed out in Slack by @maxbrunsfeld
How did this regression sneak in? Maybe we should experiment with some (simple) means of preventing this kind of breakage in the future — ideally some type of automated test. If not, we should at least have some manual smoke testing process that should pass anytime we touch GUI bits.
I think there are some testing frameworks that do "visual diffing". Take before and after screenshots and test if pixels changed. No idea how easy it would be to add something like that.
Yeah, have a list of things to manually click through in the UI. It wouldn't catch everything and there are probably community packages that we constantly break, but at least for the core UI.
Another solution would be to make components more robust and independant. Like in this PR's case, the CSS class
So yeah, maybe back to a smoke test?
We might could go even further and have a "master" theme from where other color variations could import the styles from. I'll have to test that one day.