New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 32-bit Windows builds on VSTS #18048

Merged
merged 2 commits into from Sep 14, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Sep 13, 2018

Description of the Change

This change enables 32-bit builds of Atom on VSTS by using an intermediate launcher script which downloads 32-bit Node and runs it using the 32-bit cmd.exe.

Alternate Designs

It'd be better if VSTS supported build architectures in its NodeTool task, tracked here: Microsoft/azure-pipelines-tasks#6671

Why Should This Be In Core?

It's for Atom's release builds.

Benefits

32-bit Nightly builds.

Possible Drawbacks

Increased complexity, but only for Windows builds on VSTS. This change does not affect script/build.cmd in local builds.

Verification Process

  • Verified that the script works on my local machine for 32-bit and 64-bit Windows builds
  • Verified that the script works on VSTS for 32-bit and 64-bit Windows builds
  • Windows 32-bit build tests pass on VSTS

Applicable Issues

Fixes #17668.

@daviwil daviwil changed the title from Enable 32-b to Enable 32-bit Windows builds on VSTS Sep 13, 2018

@daviwil daviwil changed the title from Enable 32-bit Windows builds on VSTS to WIP: Enable 32-bit Windows builds on VSTS Sep 13, 2018

daviwil added some commits Jul 26, 2018

@daviwil daviwil changed the title from WIP: Enable 32-bit Windows builds on VSTS to Enable 32-bit Windows builds on VSTS Sep 14, 2018

@daviwil daviwil merged commit 9c58988 into master Sep 14, 2018

2 of 4 checks passed

Atom Production Branches #1.32.0-dev+20180914.1 failed
Details
Atom Pull Requests #20180914.2 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-vsts-windows-x86 branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment