New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom Ubuntu 18.04 container for VSTS Linux builds #18049

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Sep 13, 2018

Description of the Change

This change seeks to fix a recurring failure in our VSTS CI tests on Linux possibly caused by a build dependency on Ubuntu 16.04 that clashes with Electron 2.0.8+. The fix is to use a custom container image based on Ubuntu 18.04 so that we can build and test successfully with Electron 2.0.8+.

Alternate Designs

Find the issue in Electron causing our tests to fail and get it fixed, but that will be much more time consuming. I'll pursue this also but only after getting our builds green again.

Why Should This Be In Core?

It fixes an issue preventing our Linux CI runs on VSTS from succeeding reliably.

Benefits

It fixes an issue preventing our Linux CI runs on VSTS from succeeding reliably.

Possible Drawbacks

Possibly slower builds due to the upgrade step.

Verification Process

  • Ensure CI passes after using new container image
  • Try a build generated on Ubuntu 18.04 on an Ubuntu 16.04 VM and make sure it runs correctly and passes a basic sanity check

Applicable Issues

None.

@daviwil daviwil changed the title from Make sure latest apt-get packages are installed on Linux VSTS image to Use a custom Ubuntu 18.04 container for VSTS Linux builds Sep 14, 2018

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 14, 2018

Member

Build of Atom from the Ubuntu 18.04 container works successfully on Ubuntu 16.04. :shipit:

Member

daviwil commented Sep 14, 2018

Build of Atom from the Ubuntu 18.04 container works successfully on Ubuntu 16.04. :shipit:

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 14, 2018

Member

Also huge thanks to @Arcanemagus who provided some valuable insight and a great starting point for the Linux container image

Member

daviwil commented Sep 14, 2018

Also huge thanks to @Arcanemagus who provided some valuable insight and a great starting point for the Linux container image

@daviwil daviwil merged commit aef6ba3 into master Sep 14, 2018

3 checks passed

Atom Pull Requests #20180914.8 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-fix-linux-build branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment