New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions for bad package.json when looking for Atom repo in pwd #18060

Merged
merged 1 commit into from Sep 15, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Sep 15, 2018

Description of the Change

Fixes an issue encountered by @Arcanemagus where opening Atom in a folder with a malformed package.json will cause Atom's main process to crash.

Alternate Designs

None.

Benefits

No more 馃挜

Possible Drawbacks

None.

Verification Process

  • Opened Atom in a folder with the following package.json and verified that it does not crash
{ name: "atom": , }

Applicable Issues

Fixes #18058.

@daviwil daviwil merged commit 699db30 into master Sep 15, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Atom Pull Requests #20180915.2 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 15, 2018

Member

Looks like AppVeyor is failing pretty regularly now, I'll look at that on Monday.

Member

daviwil commented Sep 15, 2018

Looks like AppVeyor is failing pretty regularly now, I'll look at that on Monday.

@daviwil daviwil deleted the dw-catch-json-exception branch Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment