New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[one-{dark,light}-ui] Apply focus styles to checkbox inputs #18069

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@wbinnssmith
Contributor

wbinnssmith commented Sep 17, 2018

Description of the Change

Previously, there was no way of visually identifying whether a checkbox was focused or not.

This adds input-checkbox to the selector in each theme's inputs.less to apply the
same border/box-shadow style to indicate focus to checkbox inputs when they are focused.

Alternate Designs

Could create a visual indication through some other means (not re-using .focus()) but this seems to make the sense

Why Should This Be In Core?

Checkboxes are implemented in core

Benefits

Makes checkboxes more accessible to sighted users who use keyboards to traverse inputs

Possible Drawbacks

N/A

Verification Process

Tab through settings-view and verify screenshots:

Before ("Automatically updated" focused):

After:

Applicable Issues

N/A

[one-{dark,light}-ui] Apply focus styles to checkbox inputs
This adds input-checkbox to the selector in each theme's `inputs.less` to apply the
same border/box-shadow style to indicate focus to checkbox inputs when they are focused.

Previously, there was no way of visually identifying whether a checkbox was focused or not.
@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 17, 2018

Member

Awesome, thanks a bunch @wbinnssmith!

Member

daviwil commented Sep 17, 2018

Awesome, thanks a bunch @wbinnssmith!

@daviwil daviwil merged commit 4814a8e into master Sep 17, 2018

3 checks passed

Atom Pull Requests #20180917.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the fb-wbinnssmith/checkbox-focus branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment