New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin @atom/nsfw to 1.0.18 #18071

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Sep 17, 2018

Description of the Change

This change pins @atom/nsfw to version 1.0.18 to avoid a crash that appears in version 1.0.19+ of this module. Once the underlying issue has been resolved we'll bump the version back to latest.

Alternate Designs

None, aside from taking the time to fix the underlying issue.

Why Should This Be In Core?

Resolves a native code crash that caused recurring CI failures.

Benefits

CI is more stable.

Possible Drawbacks

None.

Verification Process

  • Renderer process tests succeed without crashes locally on Windows after 10 runs
  • CI is green on VSTS and AppVeyor after a few successful runs.

Applicable Issues

atom/nsfw#1

Pin @atom/nsfw to 1.0.18
This change is intended to temporarily resolve some issues we've been 
seeing on 64-bit Windows builds in CI.  We'll upgrade to the latest 
@atom/nsfw once the native module problem has been resolved.

@daviwil daviwil changed the title from WIP: Investigate AppVeyor build failures to Pin @atom/nsfw to 1.0.18 Sep 24, 2018

@daviwil daviwil merged commit 31ee4fb into master Sep 24, 2018

3 checks passed

Atom Pull Requests #9635 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-fix-appveyor-builds branch Sep 24, 2018

daviwil added a commit that referenced this pull request Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment