New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a non-zero error code when windows-run.js CI script fails on VSTS #18074

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Member

daviwil commented Sep 18, 2018

Description of the Change

In PR #18048 I introduced a new CI script called windows-run.js which handles launching Atom build tasks using a 32-bit or 64-bit Node.js so that we can generate 32-bit builds of Atom on VSTS. This script was missing proper error propagation, meaning that failed builds or test runs were being reported as successful because the script didn't report the failure properly (see the 64-bit Windows test run in this VSTS job). This PR resolves that issue.

Alternate Designs

None.

Why Should This Be In Core?

It's a CI script for Atom.

Benefits

Errors will be reported correctly in Windows CI builds.

Possible Drawbacks

None.

Verification Process

  • Recurring Windows test failure actually shows up as red on VSTS

Applicable Issues

None.

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 18, 2018

Member

It wasn't the specific failure I was looking for, but this run definitely verified that the fix causes Windows tests to report failure successfully:

https://github.visualstudio.com/Atom/_build/results?buildId=8008&view=logs

Member

daviwil commented Sep 18, 2018

It wasn't the specific failure I was looking for, but this run definitely verified that the fix causes Windows tests to report failure successfully:

https://github.visualstudio.com/Atom/_build/results?buildId=8008&view=logs

@daviwil daviwil merged commit 7d15422 into master Sep 18, 2018

2 of 3 checks passed

Atom Pull Requests #8008 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment