Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update soft wrap margins on gutter re-measurement #18087
Requirements for Contributing a Bug Fix
Identify the Bug
This fixes #18086. I've verified that this corrects the editor jank I observed both in my super-contrived isolated repro case and in the case where @Arcanemagus originally spotted it in atom/github#1512.
Description of the Change
I could have worked around this by manually triggering a TextEditorComponent update after the initial render has completed. That seems pretty hacky, though, and that PR already depends on features from 1.32, so I figured I might as well fix The Real Problem.
This could cause a more expensive initial render. We're already paying this price when a horizontal scrollbar is needed, though.
I've followed the repro steps from #18086 to make sure that the editor renders correctly on the first try. I've also used dev mode to verify that it fixes the way that this manifests in the GitHub package.