New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➡️ Migrate core package 'atom-dark-syntax' into ./packages #18093

Merged
merged 2 commits into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@daviwil
Member

daviwil commented Sep 24, 2018

Description of the Change

This PR migrates the core atom-dark-syntax package into atom/atom. See issue #17849 for more information.

@daviwil daviwil requested a review from jasonrudolph Sep 24, 2018

@jasonrudolph

This comment has been minimized.

Member

jasonrudolph commented Sep 24, 2018

I see that atom/atom-dark-syntax repo has a LICENSE.md file, and that it's not included as part of this migration. Is that intentional?

I ask because I've brought over the LICENSE.md file in previous migrations. If we'd prefer to exclude the LICENSE.md files from these package subdirectories, I'm totally 👌 with that, but I'd like us to do the same thing for all of them. 😇

Whaddya think?

@jasonrudolph

Just one minor question. Overall, this looks great. 🚀

@daviwil

This comment has been minimized.

Member

daviwil commented Sep 24, 2018

Good question! Maybe we should actually include them consistently after all since some packages have a non-GitHub copyright (even though they probably should have been (c) GitHub to start with). I'll add them back to both packages, thanks for pointing that out!

daviwil added some commits Sep 24, 2018

@daviwil daviwil merged commit eb98896 into master Sep 24, 2018

0 of 3 checks passed

Atom Pull Requests in progress
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@daviwil daviwil deleted the migrate-atom-dark-syntax branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment