New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ spell-check 0.74.2 #18107

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@Arcanemagus
Contributor

Arcanemagus commented Sep 25, 2018

Requirements for Contributing a Bug Fix

Identify the Bug

atom/spell-check#210

Description of the Change

Update spell-check to v0.74.2.

Alternate Designs

N/A.

Possible Drawbacks

A bug was introduced in atom/spell-check#271 that breaks something else.

Verification Process

Atom was launched in development mode with the changes applied verifying that the fix worked.

@daviwil

This comment has been minimized.

Member

daviwil commented Sep 26, 2018

Hey @Arcanemagus, can you also update this line in package.json? The tarball line gets updated automatically once you run script/bootstrap after changing the package version in the packageDependencies section so you'll never have to touch that one manually.

⬆️ spell-check
Update spell-check to v0.74.2.
@Arcanemagus

This comment has been minimized.

Contributor

Arcanemagus commented Sep 26, 2018

Updated, ran ./script/bootstrap again just to make sure that didn't change anything else 😉.

@daviwil

This comment has been minimized.

Member

daviwil commented Sep 26, 2018

Thanks a lot! Once the CI goes green again I'll merge it

@daviwil daviwil merged commit e83c8fd into master Sep 26, 2018

3 checks passed

Atom Pull Requests #20180926.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the la-spell-check-0.74.2 branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment