New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spawnSync instead of execSync in script/vsts/windows-run.js #18127

merged 1 commit into from Sep 27, 2018


None yet
1 participant

daviwil commented Sep 27, 2018

Description of the Change

This change replaces the use of child_process.execSync with child_process.spawnSync in script/vsts/windows-run.js to improve output streaming and error reporting when running the build and CI tests on Azure Pipelines (VSTS).

Alternate Designs


Possible Drawbacks

spawnSync might have some slight differences in behavior than execSync but that shouldn't matter much for a build script.

Verification Process

  • Run a CI build with a test failure introduced and ensure its error gets written out correctly in the Windows test run
  • Run a CI build that should succeed and make sure Windows build/test output is streamed as it is written

@daviwil daviwil changed the title from WIP: Use spawnSync instead of execSync in script/vsts/windows-run.js to Use spawnSync instead of execSync in script/vsts/windows-run.js Sep 27, 2018

@daviwil daviwil merged commit 4f3d457 into master Sep 27, 2018

3 checks passed

Atom Pull Requests #20180927.6 succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@daviwil daviwil deleted the dw-better-windows-run-output branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment