New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18118 by reverting PR #17774: "Write config file atomically" #18134

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@daviwil
Member

daviwil commented Sep 27, 2018

Identify the Bug

Fixes #18118.

Description of the Change

This change reverts the commit from PR #17774 which caused a new issue in Atom 1.31.0+ where settings changed in the Settings View UI never get persisted to the user's config.cson file. Reverting this change resolves this issue.

Alternate Designs

A better approach would be to fix the underlying issue introduced by this PR, but we're reverting for now so that we can ship hotfixes to unblock users affected by this issue.

Possible Drawbacks

Reverting this change could cause the original issue that was meant to be fixed by this PR to reappear, but since that issue only appears when configuration save is invoked in a package's deactivate method, we're considering that less impactful than the issue reported in #18118.

Verification Process

  • Reproduced the issue reported in #18118 on Linux with the official 1.31.0 release
  • Reproduced the issue in the latest 1.33.0-dev build
  • Verified that the issue is resolved after reverting PR #17774 and trying a new dev build

@daviwil daviwil changed the title from Revert "Write config file atomically" to Fix #18118 by reverting PR #17774: "Write config file atomically" Sep 27, 2018

@jasonrudolph

🙇

@daviwil daviwil merged commit 5d30e4e into master Sep 28, 2018

3 checks passed

Atom Pull Requests #20180927.7 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the revert-17774-fb-mdt-atomic-config-saves branch Sep 28, 2018

daviwil added a commit that referenced this pull request Sep 28, 2018

Merge pull request #18134 from atom/revert-17774-fb-mdt-atomic-config…
…-saves

Fix #18118 by reverting PR #17774: "Write config file atomically"

daviwil added a commit that referenced this pull request Sep 28, 2018

Merge pull request #18134 from atom/revert-17774-fb-mdt-atomic-config…
…-saves

Fix #18118 by reverting PR #17774: "Write config file atomically"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment