Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➡️ Migrate core package 'deprecation-cop' into ./packages #18165

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@daviwil
Copy link
Member

daviwil commented Oct 1, 2018

Description of the Change

This PR migrates the core deprecation-cop package into atom/atom. See issue #17839 for more information.

@daviwil daviwil requested a review from jasonrudolph Oct 1, 2018

@daviwil daviwil force-pushed the migrate-deprecation-cop-package branch from add9016 to 692f6c3 Oct 1, 2018

@jasonrudolph
Copy link
Member

jasonrudolph left a comment

Just a couple small suggestions. Overall 👍👍👍!

@@ -0,0 +1,20 @@
Copyright (c) 2014 <Your name here>

This comment has been minimized.

Copy link
@jasonrudolph

jasonrudolph Oct 2, 2018

Member

Can I talk you into updating this while you're in here?

Suggested change
Copyright (c) 2014 <Your name here>
Copyright (c) 2011-2018 GitHub Inc.
@@ -0,0 +1,6 @@
# Deprecation Cop package
[![OS X Build Status](https://travis-ci.org/atom/deprecation-cop.svg?branch=master)](https://travis-ci.org/atom/deprecation-cop) [![Windows Build Status](https://ci.appveyor.com/api/projects/status/0s870q5fj3vwihjx/branch/master?svg=true)](https://ci.appveyor.com/project/Atom/deprecation-cop/branch/master) [![Dependency Status](https://david-dm.org/atom/deprecation-cop.svg)](https://david-dm.org/atom/deprecation-cop)

This comment has been minimized.

Copy link
@jasonrudolph

jasonrudolph Oct 2, 2018

Member

Recommendation: Remove these status badges, since they point to the statuses for the old atom/deprecation-cop repository.

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Oct 2, 2018

Damn, got sloppy with this one, thanks for catching those!

daviwil added some commits Oct 2, 2018

@daviwil daviwil merged commit 47a12b2 into master Oct 2, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Atom Pull Requests #20181002.5 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the migrate-deprecation-cop-package branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.