New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➡️ Migrate core package 'dalek' into ./packages #18166

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@daviwil
Member

daviwil commented Oct 1, 2018

Description of the Change

This PR migrates the core dalek package into atom/atom. See issue #17838 for more information.

@daviwil daviwil requested a review from jasonrudolph Oct 2, 2018

for (let i = 0; i < duplicates.length; i++) {
const duplicate = duplicates[i]
Grim.deprecate(
`You have the core package "${duplicate}" installed as a community package. See https://github.com/atom/dalek for how this causes problems and instructions on how to correct the situation.`,

This comment has been minimized.

@Ben3eeE

Ben3eeE Oct 2, 2018

Member

This link is there to show the users the steps in the readme so they can resolve the issue. Should it be changed to the new location of the readme file?

This comment has been minimized.

@daviwil

daviwil Oct 2, 2018

Member

Yep, thanks for catching that!

This comment has been minimized.

@jasonrudolph

jasonrudolph Oct 2, 2018

Member

Nice catch, @Ben3eeE. ⚡️

@daviwil daviwil merged commit 7e3191c into master Oct 2, 2018

3 checks passed

Atom Pull Requests #20181002.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the migrate-dalek-package branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment