New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcurl3 and libcurl4 as deps for .deb package #18201

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@daviwil
Member

daviwil commented Oct 5, 2018

Identify the Bug

atom/github#848

Description of the Change

This change adds libcurl3 and libcurl4 as dependencies of the .deb package to ensure one of them is available for dugite.

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

  • Green CI builds on VSTS (Ubuntu 18.04) and Travis CI (Ubuntu 14.04)

@daviwil daviwil changed the title from Add libcurl3 libcurl-openssl1.0-dev as deps for .deb package to Add libcurl3 libcurl-openssl1.0-dev as dependencies for .deb package Oct 5, 2018

@Evpok

This comment has been minimized.

Contributor

Evpok commented Oct 6, 2018

FYI This might cause issues on recent Ubuntus due to a conflict with libcurl4 https://bugs.launchpad.net/ubuntu/+source/curl/+bug/1754686

@@ -1,6 +1,6 @@
Package: <%= appFileName %>
Version: <%= version %>
Depends: git, gconf2, gconf-service, libgtk-3-0 (>= 3.9.10), libudev0 | libudev1, libgcrypt11 | libgcrypt20, libnotify4, libxtst6, libnss3 (>= 2:3.22), python, gvfs-bin, xdg-utils, libcap2, libx11-xcb1, libxss1, libasound2 (>= 1.0.16), libxkbfile1
Depends: git, gconf2, gconf-service, libgtk-3-0 (>= 3.9.10), libudev0 | libudev1, libgcrypt11 | libgcrypt20, libnotify4, libxtst6, libnss3 (>= 2:3.22), python, gvfs-bin, xdg-utils, libcap2, libx11-xcb1, libxss1, libasound2 (>= 1.0.16), libxkbfile1, libcurl3, libcurl-openssl1.0-dev

This comment has been minimized.

@shiftkey

shiftkey Oct 15, 2018

I found out that you can do libcurl3 | libcurl4 here to prevent users on Ubuntu 18.x distros from having to do installation ping-pong, but desktop/dugite-native#109 is my current fresh hell related to this split 🤦‍♂️

This comment has been minimized.

@daviwil

daviwil Oct 15, 2018

Member

Oh, nice! I think that's probably a good solution to try here too.

@daviwil

This comment has been minimized.

Member

daviwil commented Oct 18, 2018

After trying out this change on Ubuntu 18.04, I've determined that it isn't sufficient to resolve the problem. If we require libcurl3 to be installed, it would mean that the user's libcurl4 would be uninstalled which might negatively impact other applications on their system. Using libcurl3 | libcurl4 won't work either because it'll just use the existing libcurl4 install which we already know doesn't work.

For now the best solution is to use the workaround mentioned by @rsese in this comment

I think a workaround you can use is to set LOCAL_GIT_DIRECTORY to your system installation of Git - this worked for me on 18.04:

export LOCAL_GIT_DIRECTORY=/usr

@daviwil daviwil closed this Oct 18, 2018

@daviwil daviwil deleted the dw-deb-libcurl branch Oct 18, 2018

@daviwil daviwil restored the dw-deb-libcurl branch Oct 25, 2018

@daviwil

This comment has been minimized.

Member

daviwil commented Oct 25, 2018

Reopening this PR now that the issue is fixed by desktop/dugite-native#129. I'll update this change to use the libcurl3 | libcurl4 requirement so that Atom's .deb package makes sure that one of them is installed.

@daviwil daviwil reopened this Oct 25, 2018

@daviwil daviwil changed the title from Add libcurl3 libcurl-openssl1.0-dev as dependencies for .deb package to Add libcurl3 and libcurl4 as deps for .deb package Oct 25, 2018

@daviwil daviwil merged commit 88994e2 into master Oct 25, 2018

3 checks passed

Atom Pull Requests #20181025.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-deb-libcurl branch Oct 25, 2018

daviwil added a commit that referenced this pull request Oct 29, 2018

Merge pull request #18201 from atom/dw-deb-libcurl
Add libcurl3 and libcurl4 as deps for .deb package

daviwil added a commit that referenced this pull request Oct 29, 2018

Merge pull request #18201 from atom/dw-deb-libcurl
Add libcurl3 and libcurl4 as deps for .deb package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment