New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate core package 'grammar-selector' into ./packages #18256

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Contributor

maxbrunsfeld commented Oct 17, 2018

Closes #17845

@@ -36,7 +36,7 @@ See [RFC 003](https://github.com/atom/atom/blob/master/docs/rfcs/003-consolidate
| **github** | [`atom/github`][github] | |
| **git-diff** | [`./git-diff`](./git-diff) | [#17843](https://github.com/atom/atom/issues/17843) |
| **go-to-line** | [`./go-to-line`](./go-to-line) | [#17844](https://github.com/atom/atom/issues/17844) |
| **grammar-selector** | [`atom/grammar-selector`][grammar-selector] | [#17845](https://github.com/atom/atom/issues/17845) |
| **grammar-selector** | [`./packages/grammar-selector`](./grammar-selector) | [#17845](https://github.com/atom/atom/issues/17845) |

This comment has been minimized.

@daviwil

daviwil Oct 17, 2018

Member

The path in the link text should be ./grammar-selector, that's something we changed since the earlier versions of the migration steps (I wrote it wrong in the steps 😁)

This comment has been minimized.

@maxbrunsfeld

maxbrunsfeld Oct 17, 2018

Contributor

Oh yeah, thanks for catching that!

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Oct 18, 2018

This went green when I rebuilt, but it didn't update the PR status.

@maxbrunsfeld maxbrunsfeld merged commit e937a4e into master Oct 18, 2018

3 checks passed

Atom Pull Requests #16820 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-migrate-grammar-selector-package branch Oct 18, 2018

@daviwil

This comment has been minimized.

Member

daviwil commented Oct 18, 2018

VSTS has a "Rebuild" action hidden in the "..." menu, that's the one you'll want to use to rebuild PRs. Running it with Queue doesn't cause the check state to be updated 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment