New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't soft-wrap spaces and '/' to new lines #18287

Merged
merged 3 commits into from Oct 20, 2018

Conversation

Projects
None yet
2 participants
@daviwil
Member

daviwil commented Oct 19, 2018

Identify the Bug

Fixes #18195

Description of the Change

This change fixes an issue introduced by #17949 where new soft-wrapping behavior was causing spaces and forward slashes / to be wrapped to the next line:

This change resolves the issue by changing isWordStart to consider - and / as non-word characters instead of the approach that was taken in #17949.

Alternate Designs

The alternate design in #17949 caused unwanted regressions in text wrapping.

Possible Drawbacks

Could cause unexpected wrapping behavior for some users since we haven't soft-wrapped on these characters before in the past.

Verification Process

  • Soft-wrapping on -, /, and (space) operates similarly to other editors like TextEdit (see screenshot below)
  • CI specs pass

https://user-images.githubusercontent.com/1789/46509661-4e5c6280-c801-11e8-87d3-62836d013255.png

Don't soft-wrap spaces and '/' to new lines
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>

@daviwil daviwil requested a review from maxbrunsfeld Oct 19, 2018

daviwil and others added some commits Oct 20, 2018

@maxbrunsfeld maxbrunsfeld merged commit 692c1d3 into master Oct 20, 2018

3 checks passed

Atom Pull Requests #20181020.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the dw-fix-18195 branch Oct 20, 2018

maxbrunsfeld added a commit that referenced this pull request Oct 22, 2018

Merge pull request #18287 from atom/dw-fix-18195
Don't soft-wrap spaces and '/' to new lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment