New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct comment strings for nested languages #18334

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Oct 25, 2018

Fixes #18325

Previously, when toggling comments with the Editor: Toggle Line Comments command, we blindly used the root language's comment strings. Now we use the innermost nested language that contains the first non-whitespace character of the current line.

@maxbrunsfeld maxbrunsfeld merged commit b4941cf into master Oct 25, 2018

3 checks passed

Atom Pull Requests #20181025.8 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-nested-language-comment-strings branch Oct 25, 2018

maxbrunsfeld added a commit that referenced this pull request Oct 25, 2018

Merge pull request #18334 from atom/mb-nested-language-comment-strings
Use the correct comment strings for nested languages

maxbrunsfeld added a commit that referenced this pull request Oct 25, 2018

Merge pull request #18334 from atom/mb-nested-language-comment-strings
Use the correct comment strings for nested languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment