New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style operators in typescript and flow in one-dark/light-syntax #18341

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@Ben3eeE
Member

Ben3eeE commented Oct 26, 2018

Description of the Change

@simurai When testing atom/language-javascript#612 I noticed that operators are not styled the same in typescript as they are in javascript.

This PR is an attempt to style them in one-dark and one-light syntax to look the same as javascript. I've never done anything in less so I probably messed something up 馃槄

Let me know what you think about this 馃檱

Alternate Designs

They are given the same class (keyword.operator.js) so we might be able to style all of these in the same file instead having a separate typescript.less file.

Possible Drawbacks

Someone likes that operators are not styled and doesn't want this change

Verification Process

I checked that operators are styled when using the typescript language mode.

Style operators in typescript and flow
This makes operators in typescript and flow have the same coloring as in 
javascript

@Ben3eeE Ben3eeE requested a review from simurai Oct 26, 2018

@simurai

simurai approved these changes Nov 1, 2018

Someone likes that operators are not styled and doesn't want this change

That's always possible, but since typescript and javascript are close, I think it's a good idea to make them behave the same.

This PR is an attempt to style them in one-dark and one-light syntax to look the same as javascript. I've never done anything in less so I probably messed something up 馃槄

All good. 馃憤 Thanks. 馃檱

@simurai simurai merged commit a4d297c into master Nov 1, 2018

3 checks passed

Atom Pull Requests #20181026.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the b3-style-typescript-operators branch Nov 1, 2018

maxbrunsfeld added a commit that referenced this pull request Nov 6, 2018

Merge pull request #18341 from atom/b3-style-typescript-operators
Style operators in typescript and flow in one-dark/light-syntax

maxbrunsfeld added a commit that referenced this pull request Nov 6, 2018

Merge pull request #18341 from atom/b3-style-typescript-operators
Style operators in typescript and flow in one-dark/light-syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment