New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up: languages #18374

Merged
merged 2 commits into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@Ben3eeE
Member

Ben3eeE commented Oct 31, 2018

Includes atom/language-c#302 that changes the scope for primitive types.
Includes atom/language-go#160
Includes atom/language-ruby@0208636

This doesn't change how anything looks when using any of the core syntax themes but some community themes will get primitive types in C/C++ highlighted correctly again when using tree-sitter.
Also some community themes rely on the root scope to highlight things. language-go and language-ruby is updated for this.

Ben3eeE added some commits Oct 31, 2018

@Ben3eeE Ben3eeE changed the title from :arrow_up: language-c@0.60.12 to :arrow_up: languages Nov 3, 2018

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Nov 3, 2018

/cc: @chbk this includes the language-go regression you found and the same fix for ruby.

@chbk

This comment has been minimized.

chbk commented Nov 3, 2018

@Ben3eeE I also found the same issue with language-python. The source.python scope isn't there.

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Nov 4, 2018

@chbk I don't see this issue. The source.python scope is there for me and in the grammar. Can you open a separate issue with more details?

@Ben3eeE Ben3eeE merged commit 080d6ae into master Nov 4, 2018

3 checks passed

Atom Pull Requests #20012 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ben3eeE Ben3eeE deleted the b3-primitive-c branch Nov 4, 2018

@chbk

This comment has been minimized.

chbk commented Nov 4, 2018

@Ben3eeE I opened issue 283.

maxbrunsfeld added a commit that referenced this pull request Nov 6, 2018

maxbrunsfeld added a commit that referenced this pull request Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment