New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused pane marker #18377

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
1 participant
@simurai
Member

simurai commented Nov 1, 2018

Requirements for Adding, Changing, or Removing a Feature

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must contribute a change that has been endorsed by the maintainer team. See details in the template below.
  • The pull request must update the test suite to exercise the updated functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/atom/tree/master/CONTRIBUTING.md#pull-requests.

Issue or RFC Endorsed by Atom's Maintainers

Closes #14283

Description of the Change

This makes the "pane markers" of the One themes have 2 different states:

State Screenshot
An "active" state -> grey marker 1
A "active + focused" state -> blue bar 2

This follows a similar pattern used in the tree-view, where the active file is grey, but turns blue when also focused.

active

Alternate Designs

Only show the marker when a pane has focus, but it might be nice to see, which of the panes is the active one. For example when opening a new file, you know where it will be opened.

Possible Drawbacks

Some users might prefer to keep the marker blue all the time.

Verification Process

  1. Open a file
  2. Open another file in split mode
  3. Click between tree-view and the files and observe the marker switching between grey and blue

Release Notes

N/A

@simurai

This comment has been minimized.

Member

simurai commented Nov 2, 2018

Ok, let's merge and see how it feels.

@simurai simurai merged commit d1fa1ae into master Nov 2, 2018

3 checks passed

Atom Pull Requests #20181101.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-one-theme-focus branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment