New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings-view #18390

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 3, 2018

Requirements for Contributing a Bug Fix

Identify the Bug

atom/settings-view#1052

Description of the Change

Manually validate JSON before displaying it in the settings-view.

Alternate Designs

See atom/settings-view#1065

Possible Drawbacks

See atom/settings-view#1065

Verification Process

Tests have been included to ensure that invalid JSON correctly generates an error.

Release Notes

N/A

@50Wliu 50Wliu merged commit 734a616 into master Nov 3, 2018

3 checks passed

Atom Pull Requests #19982 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-update-settings-view branch Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment