New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to emit did-change-highlighting event in TreeSitterLanguageMode #18411

Merged
merged 2 commits into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Contributor

maxbrunsfeld commented Nov 8, 2018

Fixes #18342

@maxbrunsfeld maxbrunsfeld force-pushed the mb-did-change-highlighting-fixes branch from a1f704d to 32d632b Nov 8, 2018

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Nov 8, 2018

I can confirm that this fixes #18342 (comment)

But I can still reproduce the Overlapping ranges exception though even on this branch.

@maxbrunsfeld maxbrunsfeld merged commit 49204b3 into master Nov 8, 2018

3 checks passed

Atom Pull Requests #20181108.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-did-change-highlighting-fixes branch Nov 8, 2018

maxbrunsfeld added a commit that referenced this pull request Nov 8, 2018

Merge pull request #18411 from atom/mb-did-change-highlighting-fixes
Fix failure to emit did-change-highlighting event in TreeSitterLanguageMode

maxbrunsfeld added a commit that referenced this pull request Nov 8, 2018

Merge pull request #18411 from atom/mb-did-change-highlighting-fixes
Fix failure to emit did-change-highlighting event in TreeSitterLanguageMode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment