New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub package on beta #18596

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Copy link
Member

smashwilson commented Dec 18, 2018

Update atom/github on the beta channel to include atom/github#1847 in the next stable release.

smashwilson added some commits Dec 18, 2018

@smashwilson

This comment has been minimized.

Copy link
Member

smashwilson commented Dec 18, 2018

Code-signing executable at C:\projects\atom\out\Atom Beta x64\Atom.exe
SignTool Error: The specified PFX password is not correct.
Error: Command C:\projects\atom\script\node_modules\electron-winstaller\vendor\signtool.exe sign /f C:\Users\appveyor\AppData\Local\Temp\1\win.p12 /p ****** /fd sha256 /tr http://timestamp.digicert.com /td sha256 "C:\projects\atom\out\Atom Beta x64\Atom.exe" exited with code 1
  at signFile (C:\projects\atom\script\lib\code-sign-on-windows.js:43:13)
  at module.exports (C:\projects\atom\script\lib\code-sign-on-windows.js:21:7)
  at binariesPromise.then.then.then.packagedAppPath (C:\projects\atom\script\build:100:13)
  at <anonymous>:null:null
Command exited with code 1

@daviwil are we supposed to be trying to code-sign executables in PR builds... ?

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Dec 18, 2018

I believe that since you're PR'ing into a release branch, the AppVeyor automation decided to make a signed release build. We had to roll the Windows signing certs recently, let me see if the password got broken there.

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Dec 19, 2018

Kicked off an Azure Pipelines build for final verification, once that passes I'll merge this!

https://github.visualstudio.com/Atom/_build/results?buildId=26392

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Dec 19, 2018

Good to go!

@daviwil daviwil merged commit 1804438 into 1.34-releases Dec 19, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Atom Pull Requests #1.34.0-beta1+20181219.1 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the aw/github-up-beta branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment