Upgrade to Electron 3.0

[daviwil]

This change upgrades Atom to Electron 3 . This gives us (and package authors) access to Chromium 66 and Node 10.

Related Issues

Fixes #17819.
Fixes #6666.
Fixes #18535.

TODO

• Fix test failures
• Check to see whether this PR needs to be merged: atom/tabs#552

---

General testing

• Review issues tagged with electron to see if any of them are fixed
• Verify that you can collaborate with Teletype
  • Host using Atom's current stable release can collaborate with guest using Atom with the new version of Electron
  • Guest using Atom's current stable release can collaborate with host using Atom with the new version of Electron
  • Host and guest can collaborate when both are using Atom with the new version of Electron
  Steps

  1. Open a file 1. Share a portal 1. Have a guest join the portal 1. When guest edits the text in the file, verify that the host sees those changes

Check for regressions experienced in previous upgrades

Text Input/Keybindings

See how to setup keyboard layouts.

• IME not working (#14911)

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Install an IME layout, for example Pinyin simplified
  2. Open Atom and use the layout you installed as the keyboard layout
  3. Example, if you picked Pinyin simplified type in zhongwenshuru

  Expected: in Pinyin simplified 中文输入 is expected

  

  Issues we've seen: Only shows latin first character and not every character typed.

  

• macOS: Key binding with composition characters are ignored (#15189)

  Repro steps

  1. Open your keymap.cson file and add the following:

     'atom-text-editor':
       # use hjkl; vim-like when pressing alt (word by word, paragraph by paragraph)
       # or alt (letter by letter)
       'alt-h': 'core:move-left'
       'alt-j': 'core:move-down'
       'alt-k': 'core:move-up'
       'alt-l': 'core:move-right'

  2. Save keymap.cson and reload atom.
  3. Try the new keymappings under ABC - Extended keyboard layout

  Expected: the keybindings work

  Issues we've seen: it types out the modified keys and ignores the key mapping

• macOS: Composition characters mess up insertion point (#15344)

  Repro steps

  1. Open keymap.cson and add the following:

     'atom-text-editor':
       'alt-n': 'core:move-down'
       'alt-o': 'core:move-down'

  2. Have the following in your buffer:

     Foo
     Bar
     

  3. Have the cursor at the beginning of file(before F character) Type alt-n, then arrow right, then insert a character. Observe that the character is inserted at the beginning of the line (where the alt-n left you).
  4. Repeat steps using alt-o instead of alt-n.

  Expected: Both alt-o and alt-n behave the same

  Issues we've seen:
  

• Ubuntu: Keystrokes involving ctrl resolve to the default layout instead of the active layout (#13170)

  Repro steps

  This should be tested on Linux with gnome

  1. Install a Linux ditro with gnome, for example Ubuntu
  2. Install French AZERTY and English US QWERTY layouts
  3. Change the default layout to be French AZERTY
  4. Open Atom and switch to English US QWERTY layout
  5. Press ctrl-w

  Expected: core:close to dispatch (Or the keybinding-resolver to resolve to ctrl-w). Should be resolving to the keyboard layout that is chosen and not the OS default layout.

  Issues we've seen: core:undo dispatched because it was resolved as ctrl-z because AZERTY has Z where W is on QWERTY.

• Other keyboard layouts on new Electron version

  • macOS: ABC - Extended
  • macOS: Slovak
  • macOS: U.S. International
  • macOS: Squirrel (https://github.com/rime/squirrel)
  • macOS: Full-Width Alphanumeric (Google) - Japanese layout (https://www.google.co.jp/ime/)
  • Windows: U.S.
  • Linux: Pinyin Simplified

UI

• tree-view drag image (atom/tree-view#1054)

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Open a project in Atom with multiple files and a few folders
  2. Drag a file into a folder

  Expected:
  

  Issues we've seen:

  

• drag-and-drop indicator (atom/tree-view#1055, atom/tabs#426, atom/tabs#437)

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Open Atom with a few folder projects on tree-view (you can do this on terminal in a directory that has existing folder and having a space between each folder. Example: atom folderA folderB folderC)
  2. Drag and drop all of the folders to reorder them on Atom

  Expected:
  The placeholder indicates where the folder/project is being dropped to.

  

  Issues we've seen:
  No placeholder shows up after drag and dropping

  

• Large file rendering (#16591)

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Open a file that has over one million lines
  2. Scroll down to the bottom

  Expected: To not regress the number of lines that can be rendered. Rendering to be correct for lines past a certain point. Atom 1.25 can render around 800k to 1 million lines correctly.

  Issues we've seen: Increased number of lines rendered but bad rendering past a certain point

  

• Loss of subpixel AA when the cursor is at the end of long lines (#16889, #16595)

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Open text-editor.js in Atom
  2. Copy the first 21 lines to a new untitled window
  3. Turn on soft wrapping and change language mode to javascript
  4. Resize the Window so it's soft wrapped
  5. On line 15 type a until the you reach the end of the window

  Expected: To not lose subpixel AA

  Issues we've seen: Loss of subpixel AA. Both when soft wrapping was enabled and disabled.

  

• Scrolling horizontally shift + scroll wheel (#12696 (comment))

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Open a file that has long lines
  2. Turn off soft wrapping and resize the window so you have a horizontal scrollbar
  3. Press shift and scroll in both directions using the mouse wheel

  Expected: File to scroll horizontally in both directions

  Issues we've seen: File does not scroll horizontally at all in any direction

• Scrollbars misbehaving on the first file that is opened (#12696 (comment))

  Repro steps

  1. Open Atom
  2. Open some file that has content enough to have a vertical scrollbar
  3. Close Atom
  4. Open Atom and look at the vertical scrollbar

  Expected: Scrollbar to be visible

  Issues we've seen: Scrollbar is not visible and is flickering when you are editing

• Middle clicking on unsaved tab (#15197)

  • macOS
  • Ubuntu
  Repro steps

  1. Open Atom and open a new unsaved file.
  2. Make edits to the unsaved file and middle click on the tab.

  Expected:
  Clicking save/cancel or the options on the dialog works.

  Issues we've seen:
  The UI and the dialog is unable to receive mouse clicks. You can still choose options via Keyboard, but not mouse.

• Linux: Atom scrolls even when not focused (#15482)

  Repro steps

  1. Open Atom with a large enough file that has a scrollbar
  2. Open a different application and place it over the Atom window
  3. Scroll with the mouse inside the other window
  4. Focus the Atom window

  Expected: Atom window should keep the original scroll position

  Issues we've seen: The Atom window scrolls after it is focused

Other

• Deprecation warnings (#12696 (comment))

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  This should be tested on macOS, Linux and Windows with community packages installed

  1. Open Atom
  2. Open the Developer tools console on the master branch and check for deprecation warnings
  3. Open the Developer tools console on the electron upgrade branch and check for deprecation warnings
  4. Compare the two outputs

  Expected: No new deprecation warnings

  Issues we've seen: New deprecation warnings both from core and community packages

• Supported Versions of OS (#15297)

  • macOS
  • Windows 10
  • Ubuntu
  Repro steps

  1. Check the list of supported platforms Electron Master
  2. Check what version is listed as minimum for each platform on https://atom.io and https://atom.io/faq

  Expected: https://atom.io and https://atom.io/faq to display the same versions as the Electron documentation

  Issues we've seen: macOS version support changed and https://atom.io and https://atom.io/faq was not updated

• macOS : Native tabs (#14711)

  Repro steps

  1. Open two atom windows on mac
  2. Go to View in menus and check Show Tab Bar
     
  3. Do this for both Atom windows.
  4. Drag one atom window to the other via tab bar

  Expected:
  Native Tab bar shows up and able to drag different windows to each other. Also make sure UI isn't messed up.

  Issues we've seen:
  Native Tab Bar doesn't work and messes up UI when enabled

• Ubuntu with KDE: Menu uses 100% CPU (electron/electron#8455, #13885)

  Repro steps

  1. Install Atom on Ubuntu KDE. [instructions]
  2. Enable KDE plasma global menu: Right-click on the desktop -> Add Panel => Application Menu Bar. [demo]
  3. Start Atom.
  4. Try to use the desktop menu.

  Expected:
  Desktop menu items work

  Issues we've seen:
  Desktop menu items do nothing when you click on things.

• macOS: Slovak QWERTZ (atom/atom-keymap#223)

  Repro steps

  1. Install Slovak keyboard layout on mac
  2. Open keyboard viewer to see the keys are are suppose to show up and open keyboard resolver on atom.
  3. hit cmd+'.

  Expected: Resolves to cmd+' like it shows on keyboard viewer on mac.

  Issues we've seen: It resolves to ctrl+§

• macOS: IME jump (#15696)

  Repro steps

  1. Install an IME layout, for example Chinese pinyin
  2. Type one character

  Expected:
  Expected the IME to be positioned at under the character you entered
  Issues we've seen: The IME window is in the top left corner. When you enter the second character it jumps to be positioned under the text

[eli-schwartz]

Over in Arch Linux, we've been packaging an unofficial electron 3.x package for the past month. Although it mostly works, we did receive a bug report with a proposed resolution that we've forwarded to atom/tabs#552

[Aerijo]

Segmentation fault in this issue. Looks like somethings been deprecated.

[50Wliu]

Deprecations have already been fixed in fs-plus 3.1.1, which is in this PR.

[ChrisLahaye]

Over in Arch Linux, we've been packaging an unofficial electron 3.x package for the past month. Although it mostly works, we did receive a bug report with a proposed resolution that we've forwarded to atom/tabs#552

Which package? In the official repository or AUR?

[eli-schwartz]

In the official repository:
https://www.archlinux.org/packages/community/x86_64/atom/
https://www.archlinux.org/packages/community/x86_64/electron/
https://www.archlinux.org/packages/community/x86_64/apm/

It's kind of a requirement for entry, since we don't really want to provide packages with large vendored dependencies (especially ones that don't use our packaging CFLAGS etc.) and we have a standalone electron package.

[Ben3eeE]

There are some workarounds in atom-keymap that we should be able to remove when this is merged.

https://github.com/atom/atom-keymap/blob/81bd7b80ab1a52594500bf62977a5ad61f02ff87/src/helpers.coffee#L218-L222

https://github.com/atom/atom-keymap/blob/81bd7b80ab1a52594500bf62977a5ad61f02ff87/src/helpers.coffee#L231-L232