Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with linter-js-standard-engine #18650

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

smashwilson commented Jan 4, 2019

Requirements for Adding, Changing, or Removing a Feature

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must contribute a change that has been endorsed by the maintainer team. See details in the template below.
  • The pull request must update the test suite to exercise the updated functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/atom/tree/master/CONTRIBUTING.md#pull-requests.

Issue or RFC Endorsed by Atom's Maintainers

Nah. It's a one-line change to the package.json.

Description of the Change

I use the linter-js-standard-engine package as a linting service provider for atom-ide-ui. It's great, because it uses the actual version of standard (or eslint, or whatever) from your package.json, and it avoids a host of issues that can arise from linter version drift.

In the Atom repository, though, standard is only a dependency within the script/ directory, so linter-js-standard-engine won't pick it up. I'm adding a bit of metadata to the package.json to override its default linter location logic and find the correct one.

Alternate Designs

Using a different linter package? Dealing with having a dirty package.json all the time? Get used to running script/lint and doing it by hand instead?

Possible Drawbacks

Increases clone and download size by 54 bytes.

Verification Process

  1. Run apm install linter-js-standard-engine atom-ide-ui.
  2. Clone and open atom/atom. Open an editor on JavaScript source.
  3. Ensure that there's no "unable to load linter" error in the diagnostics panel.
  4. Add a semicolon and save the file. Ensure that the diagnostic appears.

Release Notes

N/A

@smashwilson smashwilson changed the title Specify the path to the standard linter under `script/` Compatibility with linter-js-standard-engine Jan 4, 2019

@smashwilson smashwilson merged commit 728aa0b into master Jan 4, 2019

3 checks passed

Atom Pull Requests #20190104.7 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/linter-standard-engine branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.