Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the reversed option to Selection.setBufferRange #18659

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@oggy
Copy link
Contributor

commented Jan 8, 2019

Description of the Change

As it says on the tin. The option is useful when you need to create multiple selections, each with their own reversed flag. Since TextEditor.setSelectedBufferRanges doesn't take an array of reversed flags, the only way I can find is to set the flags separately using this option.

Release Notes

Document the reversed option to Selection.setBufferRange.

@rafeca

rafeca approved these changes Apr 26, 2019

Copy link
Contributor

left a comment

Thanks for contributing! LGTM 😃

@rafeca rafeca merged commit 28e8099 into atom:master Apr 26, 2019

2 of 3 checks passed

Atom Pull Requests #20190108.1 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca self-assigned this Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.