Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Block decoration ordering #18759

Merged
merged 4 commits into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@smashwilson
Copy link
Member

smashwilson commented Jan 28, 2019

An idea for an API to explicitly order block decorations that occur at the same screen row in a TextEditor. This came out of our work in atom/github#1913.


View rendered docs/rfcs/004-decoration-ordering.md

smashwilson added some commits Jan 28, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Feb 1, 2019

FYI: My current plan is to merge this at COB today (Eastern time) unless there are any objections.

@kuychaco
Copy link
Member

kuychaco left a comment

Looks good to me! Thanks @smashwilson for the thoughtful RFC and for tackling this ♥️

@daviwil

daviwil approved these changes Feb 1, 2019

Copy link
Member

daviwil left a comment

All sounds good to me! Just one non-blocking question

Show resolved Hide resolved docs/rfcs/004-decoration-ordering.md

@smashwilson smashwilson merged commit 21d4e27 into master Feb 1, 2019

3 checks passed

Atom Pull Requests #20190201.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/rfc/marker-ordering branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.