Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dark mode title bar theme in macOS Mojave #18761

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented Jan 29, 2019

Identify the Bug

Fixes #18111

Description of the Change

This change makes a small tweak to Atom's Info.plist file to enable the display of a dark title bar in macOS Mojave's dark mode.

Alternate Designs

No alternate designs.

Possible Drawbacks

None.

Verification Process

  • Build Atom with this change and verify that dark title bar is used in Mojave dark mode:

Before

image

After

image

Release Notes

When using macOS Mojave's dark mode, Atom now shows a dark title bar

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Jan 30, 2019

Azure Pipelines failures seem to be test flakes so I'll go ahead and merge this since it isn't a real code change.

@daviwil daviwil merged commit d4fe5cc into master Jan 30, 2019

2 of 3 checks passed

Atom Pull Requests #20190129.5 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-mojave-dark-title-bar branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.