Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix restart behavior for "Restart and Install Update" on macOS #18775
Identify the Bug
Description of the Change
This change introduces an additional boolean property on
It's possible that a better design could be found through refactoring Atom's shutdown logic, but that approach is much more likely to introduce new regressions and unexpected behavior.
This solution is simple enough that it shouldn't have any drawbacks other than the introduction of another boolean flag. The upside, however, is that this boolean only needs to be checked in one place and the rest of Atom's shutdown logic can be totally oblivious to it.
On macOS, Atom now restarts correctly when installing new updates with "Restart and Install Update"