Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom Jasmine reporter to actually show spec names #18788

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

smashwilson commented Feb 4, 2019

Our CI builds have been really flaky again recently, and it's difficult to see why because a renderer crash prevents anything but a bunch of dots from showing up in test output. I'm replacing our Jasmine reporter with one that displays the full name of each spec before it begins so that we can diagnose these issues more rapidly.

Remaining work

  • Do the same for the main process Mocha tests
  • Make the new reporters opt-in
@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Feb 5, 2019

Oh, right. We already are doing this for the Mocha tests:

   . AtomApplication waits until all the windows have saved their state before quitting: 28716ms

smashwilson added some commits Feb 5, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Feb 5, 2019

Merging despite failures because... the failures are what this is supposed to help us narrow down 🙈

@smashwilson smashwilson merged commit 0c29022 into master Feb 5, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Atom Pull Requests #20190205.4 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/jasmine-reporter branch Feb 5, 2019

@smashwilson smashwilson referenced this pull request Feb 11, 2019

Merged

Report macOS renderer crashes in CI #18832

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.