Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a temporary directory for ATOM_HOME in tests #18801

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@smashwilson
Copy link
Member

@smashwilson smashwilson commented Feb 5, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

N/A

Description of the Change

Use a temporary directory for configDirPath instead of inheriting the local ATOM_HOME.

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Ran the renderer tests:

script/test --core-renderer

Release Notes

  • The default Jasmine test runner uses an isolated ATOM_HOME to avoid loading user packages.
@smashwilson
Copy link
Member Author

@smashwilson smashwilson commented Feb 5, 2019

Merging despite CI gremlins 🤷‍♂️

@smashwilson smashwilson merged commit c797166 into master Feb 5, 2019
1 of 3 checks passed
1 of 3 checks passed
Atom Pull Requests #20190205.5 failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@smashwilson smashwilson deleted the aw/tests-load-local-packages branch Feb 5, 2019
UziTech added a commit to UziTech/atom-jasmine3-test-runner that referenced this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant