Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Electron 3.1.3 #18815

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

commented Feb 7, 2019

This change upgrades Atom to Electron 3.1.3. It also removes outdated restrictions on the versions of electron-chromedriver and electron-mksnapshot that lock those versions to a specific Electron major/minor version pair. As of Electron 2.0, Electron now uses Semantic Versioning so we should only need to pay attention to the major version to protect against breaking changes.

@daviwil daviwil force-pushed the electron-3.1.3 branch from 176d16d to 505cf16 Feb 7, 2019

@daviwil daviwil merged commit e81f713 into master Feb 8, 2019

4 checks passed

Atom Pull Requests #20190208.7 succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the electron-3.1.3 branch Feb 8, 2019

jasonrudolph added a commit that referenced this pull request Feb 25, 2019

Revert "Merge #18815 from atom/electron-3.1.3"
This reverts commit e81f713, reversing
changes made to bded0c1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.