Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report macOS renderer crashes in CI #18832

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@smashwilson
Copy link
Member

commented Feb 11, 2019

When we have a renderer process crash in CI, we aren't left with a lot of information to work with. #18788 lets us see at least the name of the crashing spec in the build output, but if the crash location is inconsistent, or if we can't repro locally, we're still out of luck.

If possible, I'd like to upload crash reports from each OS in our Azure DevOps builds so that we can investigate further.

Note that Windows will be the tricky one to handle here. Windows crash dumps include all of the crashed process' environment variables, which can include build secrets in release builds! To avoid leaking those, we'll need to find somewhere private to upload them instead.

Remaining work
  • macOS
    • Upload crash reports from ~/Library/Logs/DiagnosticReports as a build artifact

smashwilson added some commits Feb 11, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

Works on macOS:

screen shot 2019-02-11 at 11 40 13 am

@daviwil

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Fantastic!

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

Honestly it might even be worth narrowing this PR to only implement macOS and tackle the other two platforms later. What do you think?

@daviwil

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Sounds fine to me!

Side note: one little trick you can use for uploading artifacts without a separate PublishBuildArtifacts is to write out a line to stdout like this:

console.log(`##vso[artifact.upload containerfolder=OldReleaseNotes;artifactname=OldReleaseNotes;]${oldReleaseNotesPath}`)

Docs: https://github.com/Microsoft/azure-pipelines-tasks/blob/master/docs/authoring/commands.md#artifact-logging-commands

@smashwilson smashwilson changed the title Report renderer crashes in CI Report macOS renderer crashes in CI Feb 12, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

one little trick you can use for uploading artifacts without a separate PublishBuildArtifacts is to write out a line to stdout

Whoa magic

@smashwilson smashwilson merged commit 8c8fb42 into master Feb 12, 2019

3 checks passed

Atom Pull Requests #20190212.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/report-crashes branch Feb 12, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

Merged with macOS to track down the crashes we've been seeing recently 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.