Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align git-diff icons #18844

Merged
merged 2 commits into from Feb 18, 2019

Conversation

Projects
None yet
1 participant
@simurai
Copy link
Member

commented Feb 14, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

Closes #18684

Description of the Change

This aligns the git-diff icons when the line numbers increase in digits. The icons are also slightly smaller to make it feel less cramped.

Before After
before after

Alternate Designs

We could move the icons to the right of the line number, but there are issues, see #18684. Also, it's nice having the fold icon close to the indent guides.

Possible Drawbacks

None

Verification Process

  • Test additions, modifications and deletions
  • Test deleting first line -> icon should be visible at the top
  • Test different font-size and line-heights
  • Test different themes
  • Test when icons are hidden -> colored stripe gets used instead

Release Notes

N/A

@simurai simurai merged commit 41a180b into master Feb 18, 2019

3 checks passed

Atom Pull Requests #20190214.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-diff-icons branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.